On Sun, 2018-01-14 at 14:46 +0100, Michal Privoznik wrote: > Apparently we can't assume that people run readline recent enough > to have rl_completion_quote_character (added in readline-5.0 > released in 2011). However, we can't compile without it. So if > not present, disable readline. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > > Frankly, I hate this patch. How far into the past do we want to go when > introducing something new? 10 years? 15? I've only written this patch > because travis is unhappy without it (I'm looking at you Mac OS/X). The problem with macOS is that Apple is shipping very old releases of a lot of GNU software. Compare that with FreeBSD, which got rid of basically all GNU software from the base system but still makes (modern versions of) it available through ports. macOS has brew, though. I've kicked off a Travis build with this commit[1] included, let's see whether configure picks up readline installed from brew instead of the obsolete one available in the base system. If it does, then we can omit your patch and... Document the version requirement somehow? If we used pkg-config to detect readline availability, that would be easy. Alas, readline only introduced pkg-config support relatively recently, so we can't do that. [1] https://github.com/andreabolognani/libvirt/commit/f2ca5da50609b814edbbb73858ce006862d4cb2e -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
