Apparently we can't assume that people run readline recent enough
to have rl_completion_quote_character (added in readline-5.0
released in 2011). However, we can't compile without it. So if
not present, disable readline.
Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
Frankly, I hate this patch. How far into the past do we want to go when
introducing something new? 10 years? 15? I've only written this patch
because travis is unhappy without it (I'm looking at you Mac OS/X).
m4/virt-readline.m4 | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/m4/virt-readline.m4 b/m4/virt-readline.m4
index 9fba5148a..34b3ff3c4 100644
--- a/m4/virt-readline.m4
+++ b/m4/virt-readline.m4
@@ -38,6 +38,19 @@ AC_DEFUN([LIBVIRT_CHECK_READLINE],[
LIBS="$lv_saved_libs $extra_LIBS"
fi
+ AC_CHECK_DECLS([rl_completion_quote_character],
+ [], [],
+ [[#include <stdio.h>
+ #include <readline/readline.h>]])
+
+ if test "$ac_cv_have_decl_rl_completion_quote_character" = "no" ; then
+ if test "$with_readline" = "yes" ; then
+ AC_MSG_ERROR([readline is missing rl_completion_quote_character])
+ else
+ with_readline=no;
+ fi
+ fi
+
# The normal library check...
LIBVIRT_CHECK_LIB([READLINE], [readline], [readline], [readline/readline.h])
--
2.13.6
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
