On Thu, Nov 16, 2017 at 01:01:57PM +0100, Andrea Bolognani wrote: > On Thu, 2017-11-16 at 11:27 +0100, Pavel Hrdina wrote: > > On Wed, Nov 15, 2017 at 12:50:05PM +0100, Andrea Bolognani wrote: > > > The compiler can warn us if we add a value to the > > > virDomainChrSerialTargetType enumeration but forget to handle > > > it properly in the code. Let's take advantage of that. > > > > > > This commit is best viewed with 'git diff -w'. > > > > This sentence should be placed under "---" as a note and not part of > > the commit message. > > I thought that hint could be useful to people looking at the commit > a few years down the line just as it's useful to the reviewer right > now, but I can leave it out if you prefer :) I'm used to putting it as note, but on the other hand it might be useful to keep it in commit message. Feel free to leave it there :). Pavel
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
