On Thu, Nov 16, 2017 at 02:00:24PM +0100, Andrea Bolognani wrote: > On Thu, 2017-11-16 at 12:30 +0100, Pavel Hrdina wrote: > > > @@ -9143,6 +9143,14 @@ qemuChrIsPlatformDevice(const virDomainDef *def, > > > return true; > > > } > > > > > > + /* If we got all the way here and we're still stuck with the default > > > + * target type for a serial device, it means we have no clue what kind of > > > + * device we're talking about and we must treat it as a platform device */ > > > > Missing full stop/period at the end of the sentence. > > Is that a thing now? It seems like *not* having the full stop is way > more common: > > $ git grep -E '\.($| \*/)' src/ | grep -iEv 'copyr|licen' | wc -l > 8166 > $ git grep -E '[^\.] \*/' src/ | wc -l > 19772 > > with the former number being bigger than reality because of API > documentation and such. Since when something that is more common does mean it's right? :) To make the argument even more absurd, why did you use the period at the end of other sentences or even in commit messages? I hoped that you've just missed it and wanted to point it out, not to start this silly and wasteful conversation. Pavel
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
