On 10/24/2017 03:35 PM, Dawid Zamirski wrote: > Original code was checking for non empty disk source before proceeding > to actually attach disk device to VM. This prevented from creating > empty removable devices like DVD or floppy. Therefore, this patch > re-organizes the loop work-flow to allow such configurations as well as > makes the code follow better libvirt practices. Additionally, adjusted > debug logs to be more helpful - removed old ones and added new which > give more valuable info for troubleshooting. > --- > src/vbox/vbox_common.c | 206 +++++++++++++++++++++++++++++++------------------ > 1 file changed, 130 insertions(+), 76 deletions(-) > There's a lot going on here, but I'm not sure how much is separable other than perhaps the debug stuff, so even though there's a lot going on ... Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
