Re: [PATCH] spec: Enable unit tests during build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/20/2017 01:51 PM, mkasik@xxxxxxxxxx wrote:
> From: Marek Kasik <mkasik@xxxxxxxxxx>
> 
> Enable unit tests so that we can catch some problems soon enough
> before the package gets to the users.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1502639
> ---
>  libvirt-glib.spec.in | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libvirt-glib.spec.in b/libvirt-glib.spec.in
> index a1ca11f..7191862 100644
> --- a/libvirt-glib.spec.in
> +++ b/libvirt-glib.spec.in
> @@ -116,6 +116,9 @@ rm -f $RPM_BUILD_ROOT%{_libdir}/libvirt-gobject-1.0.la
>  
>  %find_lang %{name}
>  
> +%check
> +%__make %{?_smp_mflags} check

Should we fail the build if 'make check' fails? E.g.

%check
if ! make %{?_smp_mflags} check; then
  cat tests/test-suite.log
  exit 1
fi

Also, please use libvirt-glib for $SUBJ prefix.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux