On Fri, Sep 29, 2017 at 09:12:34AM -0400, John Ferlan wrote:
On 09/29/2017 05:02 AM, Peter Krempa wrote:virDomainDiskSourceParse got to the point of being an ugly spaghetti mess by adding more and more stuff into it. Split out parsing of network disk information into a separate function so that it stays contained. --- I've had this patch on a branch that makes virDomainDiskSourceParse uglier, but with the recent VxHS patches I've got a merge conflict, thus I'm sending it now. Note: this patch was generated with the "patience" diff algorithm src/conf/domain_conf.c | 183 ++++++++++++++++++++++++++----------------------- 1 file changed, 99 insertions(+), 84 deletions(-)Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> Seems "safe" to me too.
Please don't push refactors or even pure code movement during the freeze. Jan
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
