Re: [PATCH] conf: Split out parsing of network disk source XML elements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 09/29/2017 05:02 AM, Peter Krempa wrote:
> virDomainDiskSourceParse got to the point of being an ugly spaghetti
> mess by adding more and more stuff into it. Split out parsing of network
> disk information into a separate function so that it stays contained.
> ---
> I've had this patch on a branch that makes virDomainDiskSourceParse
> uglier, but with the recent VxHS patches I've got a merge conflict, thus
> I'm sending it now.
> 
> Note: this patch was generated with the "patience" diff algorithm
> 
> 
>  src/conf/domain_conf.c | 183 ++++++++++++++++++++++++++-----------------------
>  1 file changed, 99 insertions(+), 84 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

Seems "safe" to me too.

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux