On Thu, Jul 13, 2017 at 10:13:25AM +0200, Michal Privoznik wrote: > On 07/12/2017 12:14 PM, Daniel P. Berrange wrote: > > This series reverts the use of the __weak__ attribute which we did > > to fix the test suite with CLang. It cause unintended problems > > elsewhere which are not practical to fix. See the second patch > > for details. > > > > Daniel P. Berrange (2): > > Revert "internal: don't use weak symbols for Win32 platform" > > Revert "Prevent more compiler optimization of mockable functions" > > > > So I thought about this too and I guess my question is - why are we not > dynamically linking with the mock libraries? What we do is use > LD_PRELOAD at runtime. However, if say virpcitest would link with > virpcimock at compile time (dynamically), we can throw away LD_PRELOAD > handling code. Basically yes, however, that's tangential to this bug & patch. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
