This series reverts the use of the __weak__ attribute which we did to fix the test suite with CLang. It cause unintended problems elsewhere which are not practical to fix. See the second patch for details. Daniel P. Berrange (2): Revert "internal: don't use weak symbols for Win32 platform" Revert "Prevent more compiler optimization of mockable functions" build-aux/mock-noinline.pl | 2 +- src/check-symfile.pl | 2 +- src/internal.h | 27 +++++---------------------- src/qemu/qemu_capspriv.h | 2 +- src/rpc/virnetsocket.h | 4 ++-- src/util/vircommand.h | 2 +- src/util/vircrypto.h | 2 +- src/util/virfile.h | 2 +- src/util/virhostcpu.h | 4 ++-- src/util/virmacaddr.h | 2 +- src/util/virnetdev.h | 8 ++++---- src/util/virnetdevip.h | 2 +- src/util/virnetdevopenvswitch.h | 2 +- src/util/virnetdevtap.h | 6 +++--- src/util/virnuma.h | 16 ++++++++-------- src/util/virrandom.h | 6 +++--- src/util/virscsi.h | 2 +- src/util/virscsivhost.h | 2 +- src/util/virtpm.h | 2 +- src/util/virutil.h | 10 +++++----- src/util/viruuid.h | 2 +- 21 files changed, 45 insertions(+), 62 deletions(-) -- 2.9.4 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list