答复: Re: [PATCH] util: increase libnl buffer size to 1M

[<lu.zhipeng@xxxxxxxxxx>]

发件人： <berrange@xxxxxxxxxx>;

收件人： <jferlan@xxxxxxxxxx>;

抄送人：芦志朋10108272; <libvir-list@xxxxxxxxxx>;

日 期 ：2017年07月11日 17:11

主 题 ：Re: [libvirt] [PATCH] util: increase libnl buffer size to 1M

>>On Mon, Jul 10, 2017 at 02:51:34PM -0400, John Ferlan wrote:
>>
> >
>> On 06/29/2017 02:05 PM, ZhiPeng Lu wrote:
>> > nl_recv() returns the error "No buffer space available"
>> > when using virsh destroy domain with 240 or more
>> > passhthrough network interfaces.
>> 
>> pass-through
>> 
>> > The patch increases libnl sock receive buffer size to 1M,
>> > and nl_recv() doesn't return error when destroying domain
>> > with 512 network interfaces.
>> > 
>> > Signed-off-by: ZhiPeng Lu <lu.zhipeng@xxxxxxxxxx>
>> > ---
>> >  src/util/virnetlink.c | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> > 
>> 
>> This feels like something that perhaps should be configurable - that is
>> some /etc/libvirt/libvirtd.conf variable; otherwise, we'll keep hitting
>> some conflated maximum based on the size of something.

>1 MB matches what systemed/udevd uses, so if we hit that limit, then  the
>system as a whole is going to struggle already. So I don't think we need
>make it configurable.

----------1M is just an experience value, and I feel that setting up a configuration item

 can accommodate the needs of different users. 

In addition, this is only the netlink socket receive buffer size that will not affect the entire system.

The default value can still be set to 128K.

芦志朋 luzhipeng

IT开发工程师 IT Development Engineer
操作系统产品部/中心研究院/系统产品 OS Product Dept./Central R＆D Institute/System Product

深圳市南山区科技南路55号中兴通讯研发大楼33楼 33/F, R&D Building, ZTE Corporation Hi-tech Road South, Hi-tech Industrial Park Nanshan District, Shenzhen, P.R.China, 518057 T: +86 755 xxxxxxxx F:+86 755 xxxxxxxx M: +86 xxxxxxxxxxx E: lu.zhipeng@xxxxxxxxxx www.zte.com.cn

原始邮件

发件人： <berrange@xxxxxxxxxx>;

收件人： <jferlan@xxxxxxxxxx>;

抄送人：芦志朋10108272; <libvir-list@xxxxxxxxxx>;

日 期 ：2017年07月11日 17:11

主 题 ：Re: [libvirt] [PATCH] util: increase libnl buffer size to 1M

On Mon, Jul 10, 2017 at 02:51:34PM -0400, John Ferlan wrote:
> 
> 
> On 06/29/2017 02:05 PM, ZhiPeng Lu wrote:
> > nl_recv() returns the error "No buffer space available"
> > when using virsh destroy domain with 240 or more
> > passhthrough network interfaces.
> 
> pass-through
> 
> > The patch increases libnl sock receive buffer size to 1M,
> > and nl_recv() doesn't return error when destroying domain
> > with 512 network interfaces.
> > 
> > Signed-off-by: ZhiPeng Lu <lu.zhipeng@xxxxxxxxxx>
> > ---
> >  src/util/virnetlink.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> 
> This feels like something that perhaps should be configurable - that is
> some /etc/libvirt/libvirtd.conf variable; otherwise, we'll keep hitting
> some conflated maximum based on the size of something.

1 MB matches what systemed/udevd uses, so if we hit that limit, then  the
system as a whole is going to struggle already. So I don't think we need
make it configurable.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list