On Mon, May 22, 2017 at 01:40:01PM +0200, Peter Krempa wrote:
Otherwise the private data entry would be kept across instances of the same VM even if it's not configured to do so. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1453142 --- src/qemu/qemu_process.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index c19bd2925..ac17da668 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6449,6 +6449,10 @@ void qemuProcessStop(virQEMUDriverPtr driver, /* clean up migration data */ VIR_FREE(priv->migTLSAlias); + /* clear previously used namespaces */ + virBitmapFree(priv->namespaces); + priv->namespaces = NULL; +
Does this mean we can kill the call to qemuDomainDestroyNamespace() from qemuProcessHandleMonitorEOF() (and possibly the whole function)? ACK either way, this should be cleaned up every time.
/* The "release" hook cleans up additional resources */ if (virHookPresent(VIR_HOOK_DRIVER_QEMU)) { char *xml = qemuDomainDefFormatXML(driver, vm->def, 0); -- 2.12.2 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list