On Tue, 2017-04-04 at 00:11 +0200, Matthias Bolte wrote: > 2017-04-02 6:50 GMT+02:00 Dawid Zamirski <dzamirski@xxxxxxxxx>: > > Hello, > > > > This is v2 with all the code review feedback addressed. Please see > > the > > cover letter in v1 here: > > https://www.redhat.com/archives/libvir-list/2017-March/msg01624.htm > > l > > > > Changes in v2: > > * checked each patch with make syntax-check individually > > * fixed missing notices in hyperv_wmi_generator.py > > * addressed an issue where a case of "v2-only" WMI classes was not > > handled properly. > > There is one final question one patch 9/10. > > One thing that's missing is a potential documentation update (see > docs/drvhyperv.html.in) and an addition to the news file (see > docs/news.xml) > Ok, I've just posted v3 addressing those: https://www.redhat.com/archives/libvir-list/2017-April/msg00071.html Thanks a lot for taking time to review my code and catching bugs :-) Regards, Dawid -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
