Hello, This is v2 with all the code review feedback addressed. Please see the cover letter in v1 here: https://www.redhat.com/archives/libvir-list/2017-March/msg01624.html Changes in v2: * checked each patch with make syntax-check individually * fixed missing notices in hyperv_wmi_generator.py * addressed an issue where a case of "v2-only" WMI classes was not handled properly. Patches 5-10 should be squashed onto 4 - those won't compile individually as the code is too inter-dependent and are kept separately just for review puroposes. Regards, Dawid Zamirski (10): hyperv: store WMI version in hypervPrivate. hyperv: introduce hypervWmiClassInfo struct. hyperv: update hypervObject struct. hyperv: add hypervWqlQuery struct. hyperv: make hypervEnumAndPull use hypervWqlQuery hyperv: update generator input file. hyperv: update wmi code generator. hyperv: add helper for getting WMI class lists. hyperv: port rest of the driver to new stucts. hyperv: add hypervInitConnection. src/Makefile.am | 2 - src/hyperv/hyperv_driver.c | 168 ++++++++------- src/hyperv/hyperv_private.h | 8 +- src/hyperv/hyperv_wmi.c | 173 +++++++++++---- src/hyperv/hyperv_wmi.h | 56 ++++- src/hyperv/hyperv_wmi_classes.h | 30 +++ src/hyperv/hyperv_wmi_generator.input | 239 ++++++++++++++++++--- src/hyperv/hyperv_wmi_generator.py | 385 +++++++++++++++++++++++++--------- 8 files changed, 810 insertions(+), 251 deletions(-) -- 2.9.3 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
