On Thu, 2017-03-30 at 16:24 -0400, Dawid Zamirski wrote: > On Thu, 2017-03-30 at 16:07 -0400, Neal Gompa wrote: > > On Thu, Mar 30, 2017 at 2:00 PM, Dawid Zamirski <dzamirski@xxxxxxxx > > m> > > > > > b/src/hyperv/hyperv_wmi_generator.py > > > old mode 100755 > > > new mode 100644 > > > > Why are you changing the mode of the file? > > > > > index 8c62882..21934fd > > > --- a/src/hyperv/hyperv_wmi_generator.py > > > +++ b/src/hyperv/hyperv_wmi_generator.py > > > @@ -1,153 +1,308 @@ > > > #!/usr/bin/env python > > > > > > -# > > > -# hyperv_wmi_generator.py: generates most of the WMI type > > > mapping > > > code > > > -# > > > -# Copyright (C) 2011 Matthias Bolte <matthias.bolte@googlemail.c > > > om > > > > > > > > > > -# > > > -# This library is free software; you can redistribute it and/or > > > -# modify it under the terms of the GNU Lesser General Public > > > -# License as published by the Free Software Foundation; either > > > -# version 2.1 of the License, or (at your option) any later > > > version. > > > -# > > > -# This library is distributed in the hope that it will be > > > useful, > > > -# but WITHOUT ANY WARRANTY; without even the implied warranty of > > > -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > > GNU > > > -# Lesser General Public License for more details. > > > -# > > > -# You should have received a copy of the GNU Lesser General > > > Public > > > -# License along with this library. If not, see > > > -# <http://www.gnu.org/licenses/>. > > > -# > > > - > > > > Please put this back. It should not have been deleted. > > > > Other than these two issues, this patch looks okay to me. > > Whoops, must have fat-fingered something in vim :-) Neither I > remember > changing the mode of the file. With mode I remember now - I first created new generator side-by-side the old one and then renamed when I was done. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
