On Fri, Feb 24, 2017 at 04:39:01PM +0530, Nitesh Konkar wrote: > On Fri, Feb 24, 2017 at 4:06 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> > wrote: > > > On Fri, Feb 24, 2017 at 11:02:33AM +0100, Peter Krempa wrote: > > > On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote: > > > > Signed-off-by: Nitesh Konkar <nitkon12@xxxxxxxxxxxxxxxxxx> > > > > --- > > > > connect.go | 54 ++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++ > > > > domain.go | 54 ++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++ > > > > domain_compat.h | 36 ++++++++++++++++++++++++++++++++++++ > > > > 3 files changed, 144 insertions(+) > > > > > > The files are improperly indented. The go files use tabs for indentation > > > while your code uses spaces. I've already pointed this out in v1. > > > > More specifically the go files use 'gofmt' for formatting. The best way > > to achieve this is to setup your editor to automatically run gofmt when > > saving files. If you are using emacs this is achieved by installing and > > using this lisp file > > > Thanks Daniel. However I am using vim and I think > gofmt -w domain.go and gofmt -w connect.go would help me > achieve the same. FYI there is a vim mode too https://github.com/fatih/vim-go Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
