Re: [PATCH go v2] Add support for perf events

[Nitesh Konkar <niteshkonkar.libvirt@xxxxxxxxx>]

On Fri, Feb 24, 2017 at 3:32 PM, Peter Krempa <pkrempa@xxxxxxxxxx> wrote:

On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote:
> Signed-off-by: Nitesh Konkar <nitkon12@xxxxxxxxxxxxxxxxxx>
> ---
>  connect.go      | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  domain.go       | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  domain_compat.h | 36 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 144 insertions(+)

The files are improperly indented. The go files use tabs for indentation
while your code uses spaces. I've already pointed this out in v1.

I had read the review on v1 but could not understand exactly whats wrong

with the indentation as everything looked aligned on applying the patch.
 Now its clear, shall send v3.  Thanks.

>
> diff --git a/connect.go b/connect.go
> index 3c53485..e24cf66 100644
> --- a/connect.go
> +++ b/connect.go
> @@ -2264,6 +2264,24 @@ type DomainStatsPerf struct {
>       StalledCyclesBackend     uint64
>       RefCpuCyclesSet          bool
>       RefCpuCycles             uint64
> +        CpuClockSet              bool
> +        CpuClock                 uint64
> +        TaskClockSet             bool
> +        TaskClock                uint64

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list