On Wed, 2017-02-22 at 17:52 +0000, Daniel P. Berrange wrote: > @@ -553,6 +553,7 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDefPtr dev, > return pciFlags; > } > } > + break; > > case VIR_DOMAIN_DEVICE_FS: > /* the only type of filesystem so far is virtio-9p-pci */ I don't get this: all switches, whether top-level with respect to the function or not, provide full coverage of the respective enum, and inside those switches all cases return explicitly, so none of them can really fall through. How is it that only this one is bothering the compiler? -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list