As always with new GCC major releases, we've tickled some new warnings. What's nice is that two of them identified genuine bugs in our code. I would push this as a build-breaker fix, but I wanted some visibility on the fourth patch before doing that, as it was not the usual type of quick fix. Daniel P. Berrange (4): Use explicit boolean comparison in OOM check libxl: fix empty string check for channel path qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags Add ATTRIBUTE_FALLTHROUGH for switch cases without break src/conf/domain_conf.c | 7 +++++++ src/conf/network_conf.c | 3 ++- src/internal.h | 8 ++++++++ src/libxl/libxl_domain.c | 2 +- src/lxc/lxc_container.c | 2 +- src/network/bridge_driver.c | 6 ++++++ src/qemu/qemu_domain_address.c | 1 + src/util/viralloc.c | 2 +- tools/virsh-edit.c | 2 +- 9 files changed, 28 insertions(+), 5 deletions(-) -- 2.9.3 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list