Re: [libvirt] [PATCH] Fix logging in libvirt_lxc controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/16/2009 01:35 PM, Amy Griffis wrote:
> The lxc controller can't see libvirtd's log level setting so it
> needs to re-query it from the environment. The parsing code has
> a few users now, so I added a new function to the internal API,
> virLogParseDefaultPriority() along the lines of the other parse
> functions.
> 

I'd say go the extra step and add something like virLogSetFromEnv, which
encapsulates the duplicate getenv calls as well.

There is also another duplicate of this code in tests/eventtest.c.

Thanks,
Cole

--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]