[...] > > Yeah, I think if this function was called MatchFS(), CheckFS() or > something among those lines I'm okay with this patch. But ProbeFS() > makes me think that the function is just probing for existing FSs on > given device. Sorry for the bikeshedding :-). No problem - I'd rather get the name right now instead of having a followup because someone didn't like the name. How about FindFS() - the function is looking to "find" if a FS exists on the disk/partition. That would mean ProbeEmpty could be FindNoFS or FindEmpty (and the fallout in the remaining patches to adjust the names). John > > ACK if you make the function name reflect what the function actually does. > > Michal > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
