On Mon, Nov 14, 2016 at 02:26:03PM -0500, Collin L. Walling wrote:
> cpu features are passed to the qemu command with feature=on/off
> instead of +/-feature.
>
> Signed-off-by: Collin L. Walling <walling@xxxxxxxxxxxxxxxxxx>
If I'm not mistaken, the "feature=on|off" syntax was added on
QEMU 2.0.0. Does current libvirt support older QEMU versions?
> ---
> src/qemu/qemu_command.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index b68da3d..a0eba0e 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -6560,12 +6560,12 @@ qemuBuildCpuModelArgStr(virQEMUDriverPtr driver,
> switch ((virCPUFeaturePolicy) cpu->features[i].policy) {
> case VIR_CPU_FEATURE_FORCE:
> case VIR_CPU_FEATURE_REQUIRE:
> - virBufferAsprintf(buf, ",+%s", cpu->features[i].name);
> + virBufferAsprintf(buf, ",%s=on", cpu->features[i].name);
> break;
>
> case VIR_CPU_FEATURE_DISABLE:
> case VIR_CPU_FEATURE_FORBID:
> - virBufferAsprintf(buf, ",-%s", cpu->features[i].name);
> + virBufferAsprintf(buf, ",%s=off", cpu->features[i].name);
> break;
>
> case VIR_CPU_FEATURE_OPTIONAL:
> --
> 2.7.4
>
--
Eduardo
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list