I'm working on the CPU model checking support in libvirt for s390x and I've found when generating the -cpu +feature,-feature command, Qemu does not like the ± syntax when adding cpu features for s390x machines and expects us to use key=value pairs (e.g. feature=on,feature=off). Since x86 Qemu code supports both the ± and key=value methods of enabling CPU features, could we switch to just using key=value syntax in libvirt or do we need to maintain the ± format as well? I assume we could do something more sophisticated than wrapping the check in an if cpu->arch == VIR_ARCH_S390X? Another option would be to just change Qemu to support both formats, but I suspect we would get push back as key=value seems to be the preferred interface. Thanks for your time. - Collin Collin L. Walling (1): qemu: command: rework cpu feature argument support src/qemu/qemu_command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list