On 13.10.2016 22:58, John Ferlan wrote: > > > On 10/06/2016 09:38 AM, Michal Privoznik wrote: >> The idea is to have function that does some checking of the >> arguments at its beginning and then have one big switch for all >> the interface types it supports. Each one of them generating the >> corresponding part of the command line. >> >> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> >> --- >> src/qemu/qemu_command.c | 13 ++++---- >> .../qemuxml2argv-net-hostdev-fail.xml | 39 ++++++++++++++++++++++ >> tests/qemuxml2argvtest.c | 4 +++ >> 3 files changed, 49 insertions(+), 7 deletions(-) >> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-net-hostdev-fail.xml >> > > Is it safe to assume that previously if the XML had "<filterref > filter='myfilter'/>, <backend tap='/dev/mytap'/>, and/or "<driver > queues='4'/>" that it would be ignored, but now there will be an error > at command line build time? Yeah. I mean, we were lying to users before letting them think we set one of those things you mentioned. We should error out. > > Hopefully we get no complaints ;-) Well, if we do, we can at least tell them sorry for fooling you :-) Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list