On Fri, Jul 29, 2016 at 03:37:38PM +0200, Ján Tomko wrote: > <memballoon model='virtio'> > <virtio revision='0'/> > </memballoon> > > https://bugzilla.redhat.com/show_bug.cgi?id=1227354 > --- > docs/formatdomain.html.in | 9 ++++ > docs/schemas/domaincommon.rng | 14 ++++++ > src/conf/domain_conf.c | 46 +++++++++++++++++++ > src/conf/domain_conf.h | 9 ++++ > .../qemuxml2argv-virtio-revision.xml | 53 ++++++++++++++++++++++ > .../qemuxml2xmlout-virtio-revision.xml | 53 ++++++++++++++++++++++ > tests/qemuxml2xmltest.c | 2 + > 7 files changed, 186 insertions(+) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-revision.xml > create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-virtio-revision.xml > > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in > index 8efd6af..3c3ec32 100644 > --- a/docs/formatdomain.html.in > +++ b/docs/formatdomain.html.in > @@ -6379,6 +6379,15 @@ qemu-kvm -net nic,model=? /dev/null > <span class='since'>Since 1.1.1, requires QEMU 1.5</span> > </p> > </dd> > + <dt><code>virtio</code></dt> > + <dd> > + <p> > + An optional <code>virtio</code> can be used to enforce a particular > + virtio revision in QEMU. The valid values for the <code>revision</code> > + are <code>0</code> and <code>1</code>. Per your cover letter the actual versions are 0.9 and 1.0, so I think we should use those and not shorten it to just 0 & 1. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list