On Thu, 2016-06-23 at 14:17 -0400, Laine Stump wrote: > On 06/23/2016 04:40 AM, Andrea Bolognani wrote: > > Unfortunately, we can't just call qemuDomainMachineIsPSeries() > > here, because we don't have a virDomainDef instance; that said, > > the open-coded check should match said function as closely as > > possible. > > Maybe you could make a separate function called something like > "qemuMachineIsPSeries() that took the arch and machinetype args > separately, then call that new function from > qemuDomainMachineIsPSeries() and from the place you've patched below. > That way there would be a single location for the logic, and no need to > worry about whether or not it matched in the future. > > Either way is fine with me though, since I doubt this will change. ACK. That could be a nice improvement. I'll look into it :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list