The pseries machine type is only available on ppc64/ppc64le, and in the same way the virt machine type is only available on armv7l/aarch64. Until either machine type is introduced on another architecture, we can perform the architecture checks in a single location instead of repeating them all over the place. Andrea Bolognani (4): qemu: Remove redundant arguments to qemuBuildSerialChrDeviceStr() qemu: Add architecture checks to qemuDomainMachineIsVirt() qemu: Introduce qemuDomainMachineIsPSeries() qemu: Use stricter checks in virQEMUCapsFillDomainDeviceDiskCaps() src/qemu/qemu_capabilities.c | 18 +++++++++--------- src/qemu/qemu_command.c | 25 ++++++++----------------- src/qemu/qemu_domain.c | 31 +++++++++++++++++++++++++------ src/qemu/qemu_domain.h | 1 + src/qemu/qemu_domain_address.c | 9 +++------ src/qemu/qemu_parse_command.c | 12 ++++-------- 6 files changed, 50 insertions(+), 46 deletions(-) -- 2.7.4 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list