Re: [PATCH 2/6] add vbox/vbox_V5_0.c for VirtualBox 5 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09.06.2016 13:07, Martin Pietsch wrote:
> ---
>  src/vbox/vbox_V5_0.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>  create mode 100644 src/vbox/vbox_V5_0.c
> 
> diff --git a/src/vbox/vbox_V5_0.c b/src/vbox/vbox_V5_0.c
> new file mode 100644
> index 0000000..4293944
> --- /dev/null
> +++ b/src/vbox/vbox_V5_0.c
> @@ -0,0 +1,13 @@
> +/** @file vbox_V5_0.c
> + * C file to include support for multiple versions of VirtualBox
> + * at runtime.
> + */
> +
> +#include <config.h>
> +
> +/** The API Version */
> +#define VBOX_API_VERSION 5000000
> +/** Version specific prefix. */
> +#define NAME(name) vbox50##name
> +
> +#include "vbox_tmpl.c"
> 

I believe this one should also update src/Makefile.am and add the .c
file into the list (just like 5/6 is doing). .h should be added to the
list in either 6/6 or alternatively, you can introduce .c and .h files
in separate patches to the repository, and then adjust Makefile and
other files to work them in. The idea is that after each single patch
'make all syntax-check check' passes without any error.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]