On 09.06.2016 13:07, Martin Pietsch wrote: > --- > src/vbox/vbox_tmpl.c | 290 ++++++++++++++++++++++++++++++++------------------- > 1 file changed, 183 insertions(+), 107 deletions(-) When sending multiple patches it's considered good practice to thread them under a cover letter. > > diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c > index 7a8205d..79ce001 100644 > --- a/src/vbox/vbox_tmpl.c > +++ b/src/vbox/vbox_tmpl.c > @@ -69,6 +69,8 @@ > # include "vbox_CAPI_v4_3.h" > #elif VBOX_API_VERSION == 4003004 > # include "vbox_CAPI_v4_3_4.h" > +#elif VBOX_API_VERSION == 5000000 > +# include "vbox_CAPI_v5_0.h" > #else > # error "Unsupport VBOX_API_VERSION" > #endif > @@ -228,18 +230,18 @@ static void nsIDtoChar(unsigned char *uuid, const nsID *iid) > memcpy(uuidinterim, iid, VIR_UUID_BUFLEN); > virUUIDFormat(uuidinterim, uuidstrsrc); > > - uuidstrdst[0] = uuidstrsrc[6]; > - uuidstrdst[1] = uuidstrsrc[7]; > - uuidstrdst[2] = uuidstrsrc[4]; > - uuidstrdst[3] = uuidstrsrc[5]; > - uuidstrdst[4] = uuidstrsrc[2]; > - uuidstrdst[5] = uuidstrsrc[3]; > - uuidstrdst[6] = uuidstrsrc[0]; > - uuidstrdst[7] = uuidstrsrc[1]; > + uuidstrdst[0] = uuidstrsrc[6]; > + uuidstrdst[1] = uuidstrsrc[7]; > + uuidstrdst[2] = uuidstrsrc[4]; > + uuidstrdst[3] = uuidstrsrc[5]; > + uuidstrdst[4] = uuidstrsrc[2]; > + uuidstrdst[5] = uuidstrsrc[3]; > + uuidstrdst[6] = uuidstrsrc[0]; > + uuidstrdst[7] = uuidstrsrc[1]; > > - uuidstrdst[8] = uuidstrsrc[8]; > + uuidstrdst[8] = uuidstrsrc[8]; > > - uuidstrdst[9] = uuidstrsrc[11]; > + uuidstrdst[9] = uuidstrsrc[11]; > uuidstrdst[10] = uuidstrsrc[12]; > uuidstrdst[11] = uuidstrsrc[9]; > uuidstrdst[12] = uuidstrsrc[10]; There is plenty of white space changes that make no sense. Just like this one. I think it should be dropped. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list