On 05/17/2016 07:48 AM, Vasiliy Tolstov wrote: > 2016-05-17 1:53 GMT+03:00 Cole Robinson <crobinso@xxxxxxxxxx>: >> I suggest explicitly rejecting the <script> option then, since at least the >> formatdomain docs make it sound like it's the only valid type=ethernet config. >> virLXCProcessSetupInterfaceTap seems like the only shared place for it though >> >> Also, this is https://bugzilla.redhat.com/show_bug.cgi?id=1325687 >> >> Patch looks fine otherwise, ACK if it's simple to reject the script bit, up to you > > > I think that script may be useful.... May be simple utilize logic to > run script like in qemu? > I think Laine was saying 'I personally don't care about ->script so I'm not planning on implementing it', so if it isn't implemented we should error explicitly rather than silently ignore it. That said it's probably not hard to get ->script to work since we already have the plumbing as you mention, so 'patches welcome' :) - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list