On 05/16/2016 12:21 PM, Laine Stump wrote: > This is identical to type='bridge', but without the "connect to a > bridge" part, so it can be handled by using the same functions (and > often even the same cases in switch statements), after renaming > virLXCProcessSetupInterfaceBridged() to virLXCProcessInterfaceTap() > and enhancing it to skip bridge-related items when brname == NULL. > > To be truly useful, we need to support setting the ip address on the > host side veth as well as guest side veth (already supported for > type='bridge'), as well as setting the peer address for both. > > The <script> element isn't supported in this patch because I have no > need for it. I'd rather add it after determining it's needed rather > than adding it for no reason and than being required to support it > forever. I suggest explicitly rejecting the <script> option then, since at least the formatdomain docs make it sound like it's the only valid type=ethernet config. virLXCProcessSetupInterfaceTap seems like the only shared place for it though Also, this is https://bugzilla.redhat.com/show_bug.cgi?id=1325687 Patch looks fine otherwise, ACK if it's simple to reject the script bit, up to you - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list