Re: [PATCH] docs: domain: document blkiotune {read, write}_{bytes, iops}_sec

[Andrea Bolognani <abologna@xxxxxxxxxx>]

On Thu, 2016-04-14 at 16:39 +0200, Pavel Hrdina wrote:
> Right, this is a better approach.  ACK with this modification.

I'm attaching the full diff, with my changes squashed
in, since my MUA seems to have garbled the previous
message somewhat and Pavel was having trouble applying
it.

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team

From 2dc2ddb4ce0d20c298a1bb22113fbe26a9e9f679 Mon Sep 17 00:00:00 2001
From: Cole Robinson <crobinso@xxxxxxxxxx>
Date: Wed, 13 Apr 2016 16:37:17 -0400
Subject: [PATCH] docs: domain: document blkiotune {read, write}_{bytes,
 iops}_sec

Added with commit 3b431929 in v1.2.2 but never documented

https://bugzilla.redhat.com/show_bug.cgi?id=1313613
---
 docs/formatdomain.html.in | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index c2955eb..fef2f25 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -991,6 +991,10 @@
     &lt;device&gt;
       &lt;path&gt;/dev/sdb&lt;/path&gt;
       &lt;weight&gt;500&lt;/weight&gt;
+      &lt;read_bytes_sec&gt;10000&lt;/read_bytes_sec&gt;
+      &lt;write_bytes_sec&gt;10000&lt;/write_bytes_sec&gt;
+      &lt;read_iops_sec&gt;20000&lt;/read_iops_sec&gt;
+      &lt;write_iops_sec&gt;20000&lt;/write_iops_sec&gt;
     &lt;/device&gt;
   &lt;/blkiotune&gt;
   ...
@@ -1025,8 +1029,22 @@
         absolute path of the device, and <code>weight</code> giving
         the relative weight of that device, in the range [100,
         1000]. After kernel 2.6.39, the value could be in the
-        range [10, 1000].<span class="since">Since 0.9.8</span></dd>
-    </dl>
+        range [10, 1000]. <span class="since">Since 0.9.8</span><br/>
+        Additionally, the following optional sub-elements can be used:
+        <dl>
+          <dt><code>read_bytes_sec</code></dt>
+          <dd>Read throughput limit in bytes per second.
+            <span class="since">Since 1.2.2</span></dd>
+          <dt><code>write_bytes_sec</code></dt>
+          <dd>Write throughput limit in bytes per second.
+            <span class="since">Since 1.2.2</span></dd>
+          <dt><code>read_iops_sec</code></dt>
+          <dd>Read I/O operations per second limit.
+            <span class="since">Since 1.2.2</span></dd>
+          <dt><code>write_iops_sec</code></dt>
+          <dd>Write I/O operations per second limit.
+            <span class="since">Since 1.2.2</span></dd>
+      </dl></dd></dl>
 
 
     <h3><a name="resPartition">Resource partitioning</a></h3>
-- 
2.5.5

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list