Re: [PATCH 3/6] vz: handle sourceless cdroms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 28.03.2016 11:00, Nikolay Shirokovskiy wrote:
> From: Mikhail Feoktistov <mfeoktistov@xxxxxxxxxxxxx>
> 
> SDK handles empty cdroms all right. We just need to
> pass "" instead of NULL (not setting is good too).
> 
> However we can get problems here. Disk detaching treats source
> as ids. Fortunately disk detaching is not supported for cdroms
> yet and for hard disks we can not get empty source - this is prohibitited
> by xml parsing code.
> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx>
> ---
>  src/vz/vz_sdk.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)

Please drop this patch from the series. I sent a new version as
a standalone patch.

Nikolay
 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]