Re: [PATCH] util: netdev: Don't crash in virNetDevSetIPAddress if @peer is NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2016-04-08 at 14:17 +0200, Peter Krempa wrote:
> > doesn't 'addr' need to be checked as well?
> 
> 'addr' is declared as ATTRIBUTE_NONNULL. Also it wasn't touched by that
> patch so I don't thinkso.

Right, never mind then.

> > I'd like to have all of these fixed in a single patch, but
> > this change is good even by itself so it's up to you :)
> 
> I'll squash the second fix in. I just didn't bother to look for a
> possible second instance.

Well, I touched that code mere hours ago so I didn't even
have to look ;)

> > ACK
> 
> Does that apply to the fixed version?

Even more so! Push away :)

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]