Re: [PATCH v2 0/3] qemu: Explicitly check for gnutls_rnd()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2016-04-07 at 11:46 -0400, John Ferlan wrote:
> >   configure: Restore CFLAGS properly after GnuTLS checks
> >   configure: Always use old_CFLAGS and old_LIBS
> >   qemu: Explicitly check for gnutls_rnd()
> > 
> >  configure.ac           | 31 +++++++++++++++++++------------
> >  src/qemu/qemu_domain.c |  6 +++---
> >  2 files changed, 22 insertions(+), 15 deletions(-)
>
> This does work for me..  Not sure I see the need for 1/3 since 2/3
> essentially uses the old_CFLAGS to save and causes you to just undo what
> you did. I don't object to having both, just not sure it's necessary.

Separate commits for separate changes. Squashing them together
would yield the same end result, but the bug fix would be sort
of lost among the noise generated by the cleanup.

> ACK series though (and thanks for digging into this),

Pushed, let's see if that makes the CI happy :)

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]