On 04/07/2016 09:29 AM, Andrea Bolognani wrote: > Patch 1 fixes a bug in configure. > > Patch 2 performs a minor cleanup. > > Patch 3 is the fix for the build issues currently experienced > on CentOS 6 (see [1]). > > Changes from v1: > > * update CFLAGS and LIBS before performing the check, so > that the compiler can actually find the function > > Cheers. > > > [1] https://ci.centos.org/view/libvirt-project/job/libvirt-daemon-build/systems=libvirt-centos-6/1120/ > > Andrea Bolognani (3): > configure: Restore CFLAGS properly after GnuTLS checks > configure: Always use old_CFLAGS and old_LIBS > qemu: Explicitly check for gnutls_rnd() > > configure.ac | 31 +++++++++++++++++++------------ > src/qemu/qemu_domain.c | 6 +++--- > 2 files changed, 22 insertions(+), 15 deletions(-) > This does work for me.. Not sure I see the need for 1/3 since 2/3 essentially uses the old_CFLAGS to save and causes you to just undo what you did. I don't object to having both, just not sure it's necessary. ACK series though (and thanks for digging into this), John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list