Hi Daniel, > > > +VBOX_DRIVER_SOURCES = \ > > + vbox/VBoxXPCOMCGlue.c vbox/VBoxXPCOMCGlue.h \ > > + vbox/vbox_driver.c vbox/vbox_driver.h \ > > + vbox/vbox_V2_2.c > > Hum, I wonder about the need of a subdirectory here, others > drivers are directly in src/ ... maybe it's a good idea, but > that's different from current practice. Actually src/ now has 140+ files and I thought it would be better if every driver got his own place ;) > affect this too > > > +#ifdef WITH_VBOX > > +#include "vbox/vbox_driver.h" > > +#endif > > #endif > > Otherwise that part of the patch looks good. > Is there really no need for checkings at configure time ? I didn't understand this, do you mean the #ifdef is not necessary? i will remove it then. Thanks, -pritesh -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list