On Wed, Mar 18, 2009 at 06:44:31PM +0100, Pritesh Kothari wrote: > Hi All, > > I have attached a patch which when applied on the HEAD as of today would > allow virtualbox support in libvirt. > > The patch works very well with the VirtualBox OSE version and the 2.2 Beta > release. Cool, thanks ! > [PATCH 1/2] contains diff of files already in libvirt. okay [...] > +VBOX_DRIVER_SOURCES = \ > + vbox/VBoxXPCOMCGlue.c vbox/VBoxXPCOMCGlue.h \ > + vbox/vbox_driver.c vbox/vbox_driver.h \ > + vbox/vbox_V2_2.c Hum, I wonder about the need of a subdirectory here, others drivers are directly in src/ ... maybe it's a good idea, but that's different from current practice. affect this too > +#ifdef WITH_VBOX > +#include "vbox/vbox_driver.h" > +#endif > #endif Otherwise that part of the patch looks good. Is there really no need for checkings at configure time ? Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list