Re: [PATCH v2 5/6] logical: Add capability to get the thin pool name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 28, 2016 at 05:44:08PM -0500, John Ferlan wrote:
> Since a future patch will start displaying thin logical volumes for a
> logical volume group thin-pool, add the ability to display at the name of
> the thin-pool name. This is done by adding 'pool_lv' to the list of
> regex's and then when a "thin" lv is found, storing that pool name.
> 
> The result will end up being the following for a vol-dumpxml:
> 
>   <source>
>     <name>thinpool_test_thin</name>
>   </source>
> 
> instead of an empty <source> </source> pair.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  docs/formatstorage.html.in            |  9 +++++++--
>  src/storage/storage_backend_logical.c | 26 ++++++++++++++++----------
>  2 files changed, 23 insertions(+), 12 deletions(-)
> 
> diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in
> index 4965a4c..2f4662c 100644
> --- a/docs/formatstorage.html.in
> +++ b/docs/formatstorage.html.in
> @@ -566,8 +566,13 @@
>          <span class="since">Since 0.4.1</span></dd>
>        <dt><code>source</code></dt>
>        <dd>Provides information about the underlying storage allocation
> -        of the volume. This may not be available for some pool types.
> -        <span class="since">Since 0.4.1</span></dd>
> +        of the volume. This is available logical pool types to display

s/available/available for/

> +        details of logical volume extent information
> +        (<span class="since">Since 0.4.1</span>)
> +        or the name of the name of the thin-pool used by the thin
> +        logical volume
> +        (<span class="since">Since 1.3.2</span>).
> +        </dd>
>        <dt><code>target</code></dt>
>        <dd>Provides information about the representation of the volume
>          on the local host. <span class="since">Since 0.4.1</span></dd>

[...]

Looks good, but you'll need to update it after we agree on the name of the new
element.

Pavel

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]