v1: http://www.redhat.com/archives/libvir-list/2016-January/msg01023.html Differences to v1: Patch 1 is the former patch 2 with the following adjuments: - Change helper name to be virStorageBackendLogicalParseVolExtents - Include all 'extent' parsing needs - including fetch/parse of 'stripes' to determine 'nextents' value, allocation of vol->source.extents, parse of groups[6] to be 'length', parse of groups[7] to be 'size' Patch 2 is new, but replaces some of the concepts from patch 3: - I rototilled the virStorageBackendLogicalParseVolExtents to remove the unnecessary trip through regex/regcomp. - Used virStringSplitCount instread and then parse the resultant string. - Removed the need for the 'stripes' fetch since it really wasn't doing what it was supposed to. - I adjusted the virstringtest to exhibit what is being parsed (it can be removed if you think that's excessive). Patches 3-5 are new - These could be combined. I left them separate to show the process... - Essentially adding a new "source" field to be used to display in the vol-dumpxml output Patch 6 is part of the old patch 4: - Since the old patch 3 isn't necessary - it's essentially gone. This just takes the patch 4 concept of changing the regex, but also applies it to the current code. John Ferlan (6): logical: Create helper virStorageBackendLogicalParseVolExtents logical: Fix parsing of the 'devices' field lvs output logical: Search for a segtype of "thin" and mark lv as sparse vol: Add thin_pool to _virStorageVolSource logical: Add capability to get the thin pool name logical: Display thin lv's found in a libvirt managed volume group docs/formatstorage.html.in | 9 +- src/conf/storage_conf.c | 5 + src/conf/storage_conf.h | 1 + src/storage/storage_backend_logical.c | 221 ++++++++++++++++------------------ tests/virstringtest.c | 11 ++ 5 files changed, 127 insertions(+), 120 deletions(-) -- 2.5.0 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list