On Wed, Jan 13, 2016 at 07:29:48AM -0500, John Ferlan wrote: > Commit id '71ce4759' altered the cgroup processing with respect to the > call to virCgroupAddTask being moved out from lower layers into the calling > layers especially for qemu processing of emulator and vcpu threads. > > What was missed in the processing was that it is possible for a code path to > return a NULL cgroup *and* a 0 return status via virCgroupNewPartition > failure when virCgroupNewIgnoreError succeeded when virCgroupNewMachineManual > returns. This was initially seen for lxc cgroup processing and patched > by comit id 'ae09988eb'. We'll make the same check here as a subsquent > patch will revert commit id 'a41c00b47' which would leave the possibility > that priv->cgroup is NULL. > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > src/qemu/qemu_cgroup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) We should be reverting commit 71ce4759, so I don't think thi sis needed Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list