On Wed, Jan 13, 2016 at 07:29:47AM -0500, John Ferlan wrote: > Commit id '90b721e43' moved where the virCgroupAddTask was made until > after the check for the vcpupin checks. However, in doing so it missed > an option where if the cpumap didn't exist, then the code would continue > back to the top of the current vcpu loop. The results was that the > virCgroupAddTask wouldn't be called. > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > src/qemu/qemu_cgroup.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c > index 1c406ce..91b3328 100644 > --- a/src/qemu/qemu_cgroup.c > +++ b/src/qemu/qemu_cgroup.c > @@ -1079,10 +1079,7 @@ qemuSetupCgroupForVcpu(virDomainObjPtr vm) > } > } > > - if (!cpumap) > - continue; > - > - if (qemuSetupCgroupCpusetCpus(cgroup_vcpu, cpumap) < 0) > + if (cpumap && qemuSetupCgroupCpusetCpus(cgroup_vcpu, cpumap) < 0) > goto cleanup; > } ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list