Re: [PATCH v3 1.5/11] admin: introduce virAdmGetVersion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> +/**
>> + * virAdmGetVersion:
>> + * @libVer: where to store the library version
>> + *
>> + * Provides version information. @libVer is the version of the
>> library and will
>> + * allways be set unless an error occurs in which case an error code
>> and a
>> + * generic message will be returned. @libVer format is as follows:
>> + * major * 1,000,000 + minor * 1,000 + release.
>> + *
>> + * NOTE: To get the remote side library version use
>> virAdmDaemonGetLibVersion
> 
> Either you meant virAdmConnectGetLibVersion here or
> virAdmDaemonGetVersion but not the one you used.  You should probably
> keep the *Connect* version for now as the future of my patch for
> renaming was not yet decided upon.  If it is, I'll change it in the
> rename patch itself.
> 
> ACK to [012].5

Fixed the minor issue and pushed the series, thank you for all reviews.

Erik

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]