v1:
1/9 - ACKed if adjusted
6/9 - ACKed
8/9 - ACKed if squashed into 4/9 --> resolves 7/9
v2:
- double empty line in private.syms is preserved (1/9)
- adjusted authors of virt-admin modules (2/9)
- removed unnecessary includes from virt-admin module (2/9)
- replaced "int" disconnected type for type "bool" (2/9)
- dropped unused command groups (2/9)
- removed unnecessary flags and adminControl struct element (2/9)
- introduction of virAdmConnectIsAlive split separately (3/9)
- remote version of admin API moved into a separate module (4/9)
- updated admin_protocol-structs (8/9)
- removed debugging leftovers from gendispatch.pl (8/9)
- properly indented if-else conditions in gendispatch.pl (8/9)
- removed unrelated paragraph, domain references, unsupported
options from virt-admin.pod and command 'connect' is now
(hopefully correctly) documented (9/9)
- introduction of vshAdmCatchDisconnect and introduction of close
callbacks had to be squashed together due to dependencies both
ways <-- review 4/9 pointed out dummy NULL close callback which
should be replaced by something relevant
since v2:
1/9 - ACKed if virGetLibvirtConfigFile is renamed
3/9 - ACKed, 'disconnected' removed, replaced by virAdmConnectIsAlive
4/9 - ACKed, admin_remote.c include moved up
5/9 - ACKed
v3:
- adjusted formatting issues (missing/extra whitespaces, missaligned
tabs)
- fixed dual assignment in virAdmConnectOpen
- cleaned some of the 'bogus' in vshAdmShowVersion
- fixed the logic in getSocketPath
- fixed coverity issues
- virt-admin -h behaves the same as --help
- virGetEnvBlockSUID replaced by virGetEnvAllowSUID
- changed the prefix for default admin URI
- close callback disposal now takes NULL for all relevant arguments
- Makefile: simplified man page pattern rule
- Makefile: fixed virt-admin recipes
- Man: reworded or deleted suggested parts
- proposed URI aliases support
Erik Skultety (11):
libvirt: Export libvirt config getters by moving them to util
virt-admin: Introduce first working skeleton
admin: Introduce virAdmConnectIsAlive
admin: Move remote admin API version to a separate module
admin: Do not generate remoteAdminConnect{Open,Close}
admin: Add URI support and introduce virAdmGetDefaultURI
livirt: Move URI alias matching to util
admin: Add support for URI aliases
admin: Add support for connection close callbacks
admin: Introduce virAdmConnectGetLibVersion
virt-admin: Provide a man page for virt-admin
.gitignore | 1 +
cfg.mk | 2 +-
daemon/admin_server.c | 9 +
include/libvirt/libvirt-admin.h | 27 ++
po/POTFILES.in | 2 +
src/admin/admin_protocol.x | 15 +-
src/admin/admin_remote.c | 216 ++++++++++++
src/admin_protocol-structs | 4 +
src/datatypes.c | 26 ++
src/datatypes.h | 17 +-
src/libvirt-admin.c | 423 ++++++++++++++++--------
src/libvirt.c | 133 +-------
src/libvirt.conf | 7 +-
src/libvirt_admin_private.syms | 1 +
src/libvirt_admin_public.syms | 5 +
src/libvirt_private.syms | 2 +
src/rpc/gendispatch.pl | 11 +-
src/util/virconf.c | 52 +++
src/util/virconf.h | 1 +
src/util/viruri.c | 92 ++++++
src/util/viruri.h | 2 +
tools/Makefile.am | 38 ++-
tools/virt-admin.c | 712 ++++++++++++++++++++++++++++++++++++++++
tools/virt-admin.h | 46 +++
tools/virt-admin.pod | 255 ++++++++++++++
25 files changed, 1801 insertions(+), 298 deletions(-)
create mode 100644 src/admin/admin_remote.c
create mode 100644 tools/virt-admin.c
create mode 100644 tools/virt-admin.h
create mode 100644 tools/virt-admin.pod
--
2.4.3
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list