On Thu, Nov 05, 2015 at 04:51:10PM -0500, John Ferlan wrote: > > > On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > > As of QEMU 0.9.1 the -drive argument can be used to configure > > all disks, so the QEMU driver can assume it is always available > > and drop support for -hda/-cdrom/etc. > > > > Many of the tests need updating because a great many were > > running without CAPS_DRIVE set, so using the -hda legacy > > syntax. > > > > Fixing the tests uncovered a bug in the argv -> xml > > convertor which failed to handle disk with if=floppy. > > > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > > --- > > > A bunch of syntax-check failures - I've attached a git am -able patch > file to resolve, but they'll cause rebase/merge issues with patch 7, but > far less changes than to resolve this one. Wow, thanks. You really didn't need to take the time to fix all those problems, but I appreciate the patch ! Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list