On 10/06/2015 03:19 AM, Martin Kletzander wrote: > On Mon, Oct 05, 2015 at 02:59:39PM -0400, Cole Robinson wrote: >> The example pvspinlock XML is: >> >> <pvspinlock/> >> >> While this is accepted by libvirt and works correctly, it's currently >> always output as a tristate like >> >> <pvspinlock state='on'/> >> >> So document that format instead >> --- >> docs/formatdomain.html.in | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > We could also clean this and others to behave as apic, kvm, etc. by > doing s/ state='on'// on line 2209 in domain_conf.c. But whichever > one you choose, ACK. > I think it's better to be explicit about the state='on' bit so personally I'd prefer not to drop it from domain_conf.c. I've pushed this fix, thanks for the review - Cole >> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in >> index efa485c..c88b032 100644 >> --- a/docs/formatdomain.html.in >> +++ b/docs/formatdomain.html.in >> @@ -1464,7 +1464,7 @@ >> <kvm> >> <hidden state='on'/> >> </kvm> >> - <pvspinlock/> >> + <pvspinlock state='on'/> >> <gic version='2'/> >> >> </features> >> -- >> 2.5.0 >> >> -- >> libvir-list mailing list >> libvir-list@xxxxxxxxxx >> https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list