Re: [PATCH] docs: domain: Show canonical pvspinlock XML

[Martin Kletzander <mkletzan@xxxxxxxxxx>]

On Mon, Oct 05, 2015 at 02:59:39PM -0400, Cole Robinson wrote:
> The example pvspinlock XML is:
>
>  <pvspinlock/>
>
> While this is accepted by libvirt and works correctly, it's currently
> always output as a tristate like
>
>  <pvspinlock state='on'/>
>
> So document that format instead
> ---
> docs/formatdomain.html.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

We could also clean this and others to behave as apic, kvm, etc. by
doing s/ state='on'// on line 2209 in domain_conf.c.  But whichever
one you choose, ACK.

> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index efa485c..c88b032 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -1464,7 +1464,7 @@
>     &lt;kvm&gt;
>       &lt;hidden state='on'/&gt;
>     &lt;/kvm&gt;
> -    &lt;pvspinlock/&gt;
> +    &lt;pvspinlock state='on'/&gt;
>     &lt;gic version='2'/&gt;
>
>   &lt;/features&gt;
> --
> 2.5.0
>
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list