On 08/11/2015 05:24 PM, Moshe Levi wrote: > > >> -----Original Message----- >> From: John Ferlan [mailto:jferlan@xxxxxxxxxx] >> Sent: Wednesday, August 12, 2015 12:01 AM >> To: Moshe Levi; Laine Stump; libvir-list@xxxxxxxxxx >> Subject: Re: [PATCH] nodedev: Fix gfeature size to be according to >> running kernel >> >> >> >> On 08/11/2015 03:28 AM, Moshe Levi wrote: >>> >>> >>>> -----Original Message----- >>>> From: sendmail [mailto:justsendmailnothingelse@xxxxxxxxx] On Behalf >>>> Of Laine Stump >>>> Sent: Tuesday, August 11, 2015 9:27 AM >>>> To: libvir-list@xxxxxxxxxx >>>> Cc: Moshe Levi >>>> Subject: Re: [PATCH] nodedev: Fix gfeature size to be >>>> according to running kernel >>>> >>>> On 08/08/2015 05:34 AM, Moshe Levi wrote: >>>>> This patch add virNetDevGetGFeaturesSize to get the supported >>>>> gfeature size from the kernel >>>>> --- >>>> >>>> This is interesting/possibly useful, but it doesn't fix the crash >>>> that users are experiencing. Here is a patch that should fix the crash: >>>> >>>> https://www.redhat.com/archives/libvir-list/2015-August/msg00382.html >>>> >>>> I would rather have that patch pushed before this one (which will >>>> mean rebasing and resolving some merge conflicts). >>> >>> Ok I will rebase once you patch is merged. >> >> Laine's patch is now pushed - I assume at least parts of this will be necessary >> since there are reports of different GFEATURE_SIZE values... > Ok, Do you want me to rebase my patch on top on this > http://libvirt.org/git/?p=libvirt.git;a=commit;h=bfaaa2b681018f3705bae17c001700a03f67d7c4 > and fixing all Laine comments or to wait for the cleanup patch you mention below? > I would say fixing a bug is more important than cleanup... Unless you feel like taking the time and applying the changes Laine proposed in separate patches rather than one mega patch... If I have a few cycles I might try to do, but no guarantees ;-) John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list