Re: [PATCH] lib: fix no zero arg check for iothread_id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 08/10/2015 05:23 PM, Peter Krempa wrote:
On Mon, Aug 10, 2015 at 17:06:31 +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1251886

We do not allow delete an iothread which id is 0 in
virDomainDelIOThread, but allow it in virDomainAddIOThread,
Also we will output an error when parse an iothread which id
is 0.

Add a check for iothread_id in virDomainAddIOThread to fix
it.
The limitation that iothread id shall not be 0 comes from the qemu
implementation so I think that we could possibly want to have iothread
id 0 in the future.

I think the check should be done in the qemu driver.

Make sense, i will move the check in qemu driver, also i will change the code for iothread pin/delete

Thanks for your quick review.

Peter

Luyao

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]