On Tue, Jun 30, 2015 at 12:41 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > Hey, > > Looks good to me, I'd name the type GVirNetworkDhcpLease rather than > GVirNetworkDHCPLease, this is consistent with > GVirConfigCapabilitiesCpuModel (and not CPUModel). Hm.. I was trying to keep it consistent with the underlying 'virNetworkDHCPLease'. > Maybe more descriptive doc for some of the fields (client id, iaid, ...) > could be useful? Or are they just obvious for someone familiar with > dhcp? I mostly copied those docs from libvirt docs. I myself don't know/remember what those are. :) But I guess if someone using this API is reading those, they'd know what they are or find out. -- Regards, Zeeshan Ali (Khattak) ________________________________________ Befriend GNOME: http://www.gnome.org/friends/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list